Some tests failed https://builds.apache.org/job/Struts-JDK7-pull-request/209/org.apache.struts$struts2-core/testReport/

OK, looks like it needs a doIntercept(..) rather than in Intercept().

On 4 August 2016 at 09:22, Lukasz Lenart notifications@github.com wrote:

Some tests failed
https://builds.apache.org/job/Struts-JDK7-pull-request/209/org.apache.struts$struts2-core/testReport/

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#108 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADwEt8Q9RTCp3xIs6DlBp2n5UJfNHMoxks5qcaFMgaJpZM4JcazT
.

Still two tests are failing ... I think it would be better to setup excludeMethods/includeMethods in test and callintercept()

Revert "WW-4628: proper decoding of parameters in query-string"

Sorry, this was a bad by not really understanding git and git making
automatic commits, it should not have modified any other code. Especially not the revert.

How would this be fixed now?

How would this be fixed now?

I fixed it already just by running git cherry-pick. (there is a jira comment about it)

I feared that monstrous issue (WW-4628) would get another round of discussion and was relieved that it was just an accident 😉

Great thanks!

@gregh3269 the best options is to not perform those reverse merges (like b6be359) if there is no conflicts.